Skip to content

Update GameMode command and increase Java support.#2279

Merged
dumptruckman merged 8 commits into
masterfrom
command_updates
Sep 22, 2020
Merged

Update GameMode command and increase Java support.#2279
dumptruckman merged 8 commits into
masterfrom
command_updates

Conversation

@nicegamer7

@nicegamer7 nicegamer7 commented Jun 7, 2020

Copy link
Copy Markdown
Member

This PR updates the Gamerule, Gamerules, and Version commands.

The Gamerule command no longer uses deprecated methods.

The Gamerules command had an NPE fixed and no longer uses deprecated methods.

The Version command had the Bitly Link Shortener fixed (#2278), pasting to Hastebin (#2277), and some general cleanup.

This was linked to issues Jun 7, 2020
Pasting to Hastebin is broken #2277
Closed
The Bitly Link Shortener Doesn't Work #2278
Closed
@nicegamer7 nicegamer7 marked this pull request as draft June 8, 2020 01:24
@nicegamer7

nicegamer7 commented Jun 8, 2020

Copy link
Copy Markdown
Member Author

Hey @main--, I sent you an email! This is just verification as explained in my email.

@nicegamer7

nicegamer7 commented Jun 8, 2020

Copy link
Copy Markdown
Member Author

I just pushed a commit that fixes (or rather, handles) #2215 and possibly #2219.

@nicegamer7

nicegamer7 commented Jun 9, 2020

Copy link
Copy Markdown
Member Author

While working on the webpaste package, I realized that all of the PasteServices had the same method used to upload data. So I decided to move that method to HttpAPIClient. One thing led to another, and I decided to make it support the use of auth tokens so that we can support the new Bitly V4 API and pasting to Gist again!

Now, PasteService and URLShortener inherit from HttpAPIClient. I also added to our pom.xml so that we don't have to have our Bitly token on GitHub. I tested out all the pasting services (including Gist) and they're all working as expected. The behaviour when there is no GitHub token (which is the default, unless a user compiles MV with one) is to ignore the pasting flag.

I realize that was a rather large commit, I guess I got carried away 😋.

@nicegamer7

nicegamer7 commented Jun 10, 2020

Copy link
Copy Markdown
Member Author

I think this PR has gotten rather large... it's now ready for review!

@nicegamer7 nicegamer7 marked this pull request as ready for review June 10, 2020 04:14
dumptruckman
dumptruckman reviewed Jun 13, 2020
View reviewed changes
Comment thread src/main/java/com/onarandombox/MultiverseCore/MultiverseCore.java
dumptruckman
dumptruckman reviewed Jun 13, 2020
View reviewed changes

@dumptruckman dumptruckman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of nice stuff in here. I think the paste stuff is definitely significant enough to have its own PR. I think we should discuss that part in discord. The other command changes look good just take a look at my notes.

Comment thread src/main/java/com/onarandombox/MultiverseCore/commands/GameruleCommand.java Outdated
Comment thread src/main/java/com/onarandombox/MultiverseCore/commands/GameruleCommand.java Outdated
Comment thread src/main/java/com/onarandombox/MultiverseCore/commands/GameruleCommand.java Outdated
Comment thread src/main/java/com/onarandombox/MultiverseCore/commands/GamerulesCommand.java
Comment thread src/main/java/com/onarandombox/MultiverseCore/commands/VersionCommand.java Outdated
@nicegamer7 nicegamer7 mentioned this pull request Jun 13, 2020
Merged
@nicegamer7 nicegamer7 force-pushed the command_updates branch 2 times, most recently from feb3dff to b09582f Compare June 14, 2020 20:07
This was unlinked from issues Jun 15, 2020
Pasting to Hastebin is broken #2277
Closed
The Bitly Link Shortener Doesn't Work #2278
Closed
@nicegamer7 nicegamer7 linked an issue Jun 15, 2020 that may be closed by this pull request
Sometimes MV Fails to Enable #2215
Closed
@nicegamer7

nicegamer7 commented Jul 29, 2020

Copy link
Copy Markdown
Member Author

I've rebased this PR and opened another for MV Portals to accommodate the change made to Buscript.

@nicegamer7 nicegamer7 mentioned this pull request Aug 14, 2020
Closed
@nicegamer7 nicegamer7 linked an issue Aug 14, 2020 that may be closed by this pull request
Java 11 - Warning: Nashorn engine is planned to be removed from a future JDK release #1939
Closed
dumptruckman
dumptruckman approved these changes Sep 22, 2020
View reviewed changes
Comment thread src/main/java/com/onarandombox/MultiverseCore/MultiverseCore.java
Comment thread src/main/java/com/onarandombox/MultiverseCore/commands/GamerulesCommand.java
@dumptruckman dumptruckman changed the title Command Updates Update GameMode command and increase Java support. Sep 22, 2020
@dumptruckman dumptruckman merged commit 51e035e into master Sep 22, 2020
@dumptruckman dumptruckman deleted the command_updates branch September 22, 2020 19:02
@nicegamer7 nicegamer7 mentioned this pull request Sep 22, 2020
Closed
@nicegamer7 nicegamer7 mentioned this pull request Oct 1, 2020
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dumptruckman dumptruckman dumptruckman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sometimes MV Fails to Enable Java 11 - Warning: Nashorn engine is planned to be removed from a future JDK release

2 participants

@nicegamer7 @dumptruckman